Review enercoop
2 fils de conversation non résolus
2 fils de conversation non résolus
Prise en compte des remarques enercoop
- Ajout de la ligne TOTAL dans le fichiers exporté
- Changement de police du bouton
- Correction bug d export de courbes
- Corrections typo
Rapports de requête de fusion
Activité
requested review from @remi-filament
assigned to @remi-filament
263 263 AND cdc.date_slot < '{end_datetime}' 264 264 """ 265 265 266 if partner_id and isinstance(partner_id, int): 266 if partner_id: 267 267 result += f" AND ((cdc.partner_id = {partner_id} " 268 if prm_id and isinstance(prm_id, int): 268 if prm_id: 269 269 result += f" AND cdc.acc_counter_id = {prm_id}) " - Commenter les lignes 261 à 269
Pour éviter une injection SQL, tu devrais faire un int(prm_id) ou int(partner_id) je pense. Je viens de tester et ça semble fonctioner !
251 if ( 252 not isinstance(operation_id, int) 253 and not isinstance(start_date, datetime) 254 and not isinstance(end_date, datetime) 255 ): 256 raise ValidationError(_("WHERE clause parameters incorrect")) 257 258 start_datetime = local_to_utc(start_date, "Europe/Paris") 259 end_datetime = local_to_utc(end_date, "Europe/Paris") 260 result = f""" 261 WHERE cdc.acc_operation_id = {operation_id} 262 AND cdc.date_slot >= '{start_datetime}' 263 AND cdc.date_slot < '{end_datetime}' 264 """ 265 266 if partner_id: 267 result += f" AND ((cdc.partner_id = {partner_id} " 268 if prm_id: 269 result += f" AND cdc.acc_counter_id = {prm_id}) " 251 if ( 252 not isinstance(start_date, datetime) 253 and not isinstance(end_date, datetime) 254 ): 255 raise ValidationError(_("WHERE clause parameters incorrect")) 256 257 start_datetime = local_to_utc(start_date, "Europe/Paris") 258 end_datetime = local_to_utc(end_date, "Europe/Paris") 259 result = f""" 260 WHERE cdc.acc_operation_id = {int(operation_id)} 261 AND cdc.date_slot >= '{start_datetime}' 262 AND cdc.date_slot < '{end_datetime}' 263 """ 264 265 if partner_id: 266 result += f" AND ((cdc.partner_id = {int(partner_id)} " 267 if prm_id: 268 result += f" AND cdc.acc_counter_id = {int(prm_id)}) " changed this line in version 2 of the diff
248 248 </t> 249 249 </t> 250 250 </select> 251 <a href="#" title="Export" target="_blank" class="fa fa-cloud-download btn btn-primary" id="export-data" > 251 <a href="#" title="Export" target="_blank" class="btn btn-primary" id="export-data" > Voici la solution pour faire ce que tu veux tout en gardant le bouton : https://sources.le-filament.com/lefilament/oacc/oacc_portal_account/-/blob/16.0/templates/operation_templates_page.xml?ref_type=heads#L36
mentioned in commit b38082bd
Veuillez vous inscrire ou vous connecter pour répondre