[fix] compute_state is not dependent of lettrage

models/scop_cotisations_idf.py

@@ -95,11 +95,8 @@ class ScopCotisationsIDF(models.Model):
         """
         partners = set(self.mapped('partner_id'))
         years = set(self.mapped('year'))
-        letters = set(self.mapped('lettrage'))
         for year in years:
             for partner in partners:
-                for letter in letters:
-                    # Group lines by partner, year, letter
                 invoice_lines = self.search([
                     ['year', '=', year],
                     ['partner_id', '=', partner.id],
@@ -113,15 +110,15 @@ class ScopCotisationsIDF(models.Model):
                     for invoice in invoices:
                         if invoice.amount_residual > 0:
                             invoice.state = 'awaiting_payments'
-                                for r in invoice.payment_or_refund_ids:
+                            for r in invoice.payments_ids:
                                 r.state = 'awaiting_payments'
                         elif invoice.amount_residual < 0:
                             invoice.state = 'overpaid'
-                                for r in invoice.payment_or_refund_ids:
+                            for r in invoice.payments_ids:
                                 r.state = 'overpaid'
                         else:
                             invoice.state = 'paid'
-                                for r in invoice.payment_or_refund_ids:
+                            for r in invoice.payments_ids:
                                 r.state = 'paid'
 
     @api.multi

models/scop_invoice_idf.py

@@ -90,15 +90,11 @@ class ScopInvoiceIDF(models.Model):
         """
         partners = set(self.mapped('partner_id'))
         years = set(self.mapped('year'))
-        letters = set(self.mapped('lettrage'))
         for year in years:
             for partner in partners:
-                for letter in letters:
-                    # Group lines by partner, year, letter
                 invoice_lines = self.search([
                     ['year', '=', year],
-                        ['partner_id', '=', partner.id],
-                        ['lettrage', '=', letter]])
+                    ['partner_id', '=', partner.id], ])
                 invoices = invoice_lines.filtered(
                     lambda l: l.type == 'inv')
                 if not invoices:
@@ -108,15 +104,15 @@ class ScopInvoiceIDF(models.Model):
                     for invoice in invoices:
                         if invoice.amount_residual > 0:
                             invoice.state = 'awaiting_payments'
-                                for r in invoice.payment_or_refund_ids:
+                            for r in invoice.payments_ids:
                                 r.state = 'awaiting_payments'
                         elif invoice.amount_residual < 0:
                             invoice.state = 'overpaid'
-                                for r in invoice.payment_or_refund_ids:
+                            for r in invoice.payments_ids:
                                 r.state = 'overpaid'
                         else:
                             invoice.state = 'paid'
-                                for r in invoice.payment_or_refund_ids:
+                            for r in invoice.payments_ids:
                                 r.state = 'paid'
 
     @api.multi