[UPD] ansible-lint

.ansible-lint

+---
+warn_list:  # or 'skip_list' to silence them completely
+    - git-latest  # Git checkouts must contain explicit version
+    - ignore-errors  # Use failed_when and specify error conditions instead of using ignore_errors
+    - no-changed-when  # Commands should not change things if nothing needs doing
+    - no-handler  # Tasks that run when changed should likely be handlers
+    - package-latest  # Package installs should not use latest

.yamllint

+---
+# Based on ansible-lint config
+extends: default
+
+rules:
+    braces:
+        max-spaces-inside: 1
+        level: error
+    brackets:
+        max-spaces-inside: 1
+        level: error
+    colons:
+        max-spaces-after: -1
+        level: error
+    commas:
+        max-spaces-after: -1
+        level: error
+    # comments enable
+    comments: enable
+    comments-indentation: enable
+    document-start: enable
+    empty-lines:
+        max: 3
+        level: error
+    hyphens:
+        level: error
+    indentation:
+        level: warning
+        indent-sequences: consistent
+        spaces: 4
+        check-multi-line-strings: true
+    key-duplicates: enable
+    line-length: disable
+    new-line-at-end-of-file: enable
+    new-lines:
+        type: unix
+    # trailing-spaces enable
+    trailing-spaces: enable
+    truthy: enable

handlers/main.yml

 ---
 
-- name: restart nrpe
-  service:
+- name: Restart nrpe
+  ansible.builtin.service:
       name: nagios-nrpe-server
       state: restarted

meta/main.yml

 ---
 galaxy_info:
-  author: Rémi
+    author: lefilament
     description: This roles deploys Nagios NRPE on every host for monitoring from Nagios
     company: Le Filament (https://le-filament.com)
     license: AGPL-3.0-or-later
-  min_ansible_version: 2.1
+    min_ansible_version: "2.1"
     platforms:
         - name: EL
           versions:
-        - 7
+              - "7"
         - name: Ubuntu
           versions:
               - trusty

tasks/main.yml

 ---
 - name: Include OS-specific variables.
-  include_vars: "{{ ansible_os_family }}.yml"
+  ansible.builtin.include_vars: "{{ ansible_os_family }}.yml"
 
 - name: Install NRPE and basic plugins
-  package:
+  ansible.builtin.package:
       name:
           - nagios-nrpe-server
           - monitoring-plugins-basic
       state: present
 
 - name: Make NRPE start with system
-  service:
+  ansible.builtin.service:
       name: nagios-nrpe-server
       state: started
       enabled: true
@@ -19,50 +19,52 @@
 # CONFIGURATION NRPE
 # --------------------------------------------------
 - name: Push NRPE configuration file
-  template:
+  ansible.builtin.template:
       src: nrpe.cfg.j2
       dest: /etc/nagios/nrpe.cfg
       owner: root
       group: root
       mode: '0644'
-  notify: restart nrpe
+  notify: Restart nrpe
   tags: nrpe_config
 
 # --------------------------------------------------
 # AJOUT CUSTOM SCRIPTs
 # --------------------------------------------------
-- name: create custom-plugin repo if not created from previous tasks
-  file:
+- name: Create custom-plugin repo if not created from previous tasks
+  ansible.builtin.file:
       name: /usr/lib/nagios/custom-plugins
       state: directory
       owner: root
       group: root
       mode: '0755'
 
-- name: get custom scripts from gitlab
-  git:
+- name: Get custom scripts from gitlab
+  ansible.builtin.git:
       repo: "https://sources.le-filament.com/lefilament/nagios-plugin.git"
       dest: "/usr/lib/nagios/custom-plugins"
       version: "master"
   when: inventory_hostname in groups.backup_server
 
-- name: set file rights on custom plugins
-  file: name={{ item }} mode=0555
+- name: Set file rights on custom plugins
+  ansible.builtin.file:
+      name: "{{ item }}"
+      mode: 0555
   with_items:
       - /usr/lib/nagios/custom-plugins/check_cloud_storage.sh
       - /usr/lib/nagios/custom-plugins/check_odoo_storage.sh
       - /usr/lib/nagios/custom-plugins/check_odoo2_storage.sh
   when: inventory_hostname in groups.backup_server
 
-- name: add check_mdstat script
-  get_url:
+- name: Add check_mdstat script
+  ansible.builtin.get_url:
       url: https://exchange.nagios.org/components/com_mtree/attachment.php?link_id=5423&cf_id=24
       dest: /usr/lib/nagios/custom-plugins/check_mdstat.sh
       mode: '0555'
   when: raid_config is defined
 
-- name: add extra scripts
-  get_url:
+- name: Add extra scripts
+  ansible.builtin.get_url:
       url: "{{ item.url }}"
       dest: /usr/lib/nagios/custom-plugins/{{ item.name }}
       mode: '0555'
@@ -70,15 +72,15 @@
   loop_control:
       label: "{{ item.name }}"
 
-- name: add nagios to www-data group
-  user:
+- name: Add nagios to www-data group
+  ansible.builtin.user:
       name: nagios
       groups: www-data
       append: true
   when: inventory_hostname in groups.owncloud_server | union(groups.docker_owncloud) | union(groups.docker_nextcloud)
 
-- name: add cron job to update available packages every day
-  cron:
+- name: Add cron job to update available packages every day
+  ansible.builtin.cron:
       name: apt update
       minute: "42"
       hour: "7"