[UPD] ansible-lint

.ansible-lint

+---
+warn_list:  # or 'skip_list' to silence them completely
+    - git-latest  # Git checkouts must contain explicit version
+    - ignore-errors  # Use failed_when and specify error conditions instead of using ignore_errors
+    - no-changed-when  # Commands should not change things if nothing needs doing
+    - no-handler  # Tasks that run when changed should likely be handlers
+    - package-latest  # Package installs should not use latest

.yamllint

+---
+# Based on ansible-lint config
+extends: default
+
+rules:
+    braces:
+        max-spaces-inside: 1
+        level: error
+    brackets:
+        max-spaces-inside: 1
+        level: error
+    colons:
+        max-spaces-after: -1
+        level: error
+    commas:
+        max-spaces-after: -1
+        level: error
+    # comments enable
+    comments: enable
+    comments-indentation: enable
+    document-start: enable
+    empty-lines:
+        max: 3
+        level: error
+    hyphens:
+        level: error
+    indentation:
+        level: warning
+        indent-sequences: consistent
+        spaces: 4
+        check-multi-line-strings: true
+    key-duplicates: enable
+    line-length: disable
+    new-line-at-end-of-file: enable
+    new-lines:
+        type: unix
+    # trailing-spaces enable
+    trailing-spaces: enable
+    truthy: enable

handlers/main.yml

 ---
 
-- name: restart-sshd
-  service: name=sshd state=restarted
+- name: Restart SSHD
+  ansible.builtin.service:
+      name: sshd
+      state: restarted

meta/main.yml

 ---
 galaxy_info:
-  author: Rémi
+    author: lefilament
     description: Role to configure backup server to allow SFTP connection from all other servers
     company: Le Filament (https://le-filament.com)
     license: AGPL-3.0-or-later
-  min_ansible_version: 2.1
+    min_ansible_version: "2.1"
     platforms:
-    - name: EL
-      versions:
-        - 7
         - name: Ubuntu
           versions:
               - bionic

tasks/main.yml

 ---
 
 - name: Create SFTP group
-  group:
+  ansible.builtin.group:
       name: sftpgroup
 
 - name: Create SFTP users
-  user:
+  ansible.builtin.user:
       name: "{{ hostvars[item].backup_sftp_user }}"
       group: sftpgroup
       password: "!"
       shell: /sbin/nologin
   with_items: "{{ groups.all | difference(groups.backup_server) }}"
 
-- name: add SFTP users public key to authorized keys
-  authorized_key:
+- name: Add SFTP users public key to authorized keys
+  ansible.posix.authorized_key:
       key: "{{ hostvars[item].host_user_public_key }}"
       user: "{{ hostvars[item].backup_sftp_user }}"
       exclusive: true
   with_items: "{{ groups.all | difference(groups.backup_server) }}"
 
-- name: create templates directory
-  file:
+- name: Create templates directory
+  ansible.builtin.file:
       name: templates
       state: directory
       mode: '0755'
@@ -30,7 +30,7 @@
   tags: sshd
 
 - name: Get sshd_config file from init_server role locally
-  get_url:
+  ansible.builtin.get_url:
       url: "https://sources.le-filament.com/lefilament/ansible-roles/init_server/-/raw/master/templates/sshd_config.j2"
       dest: templates/sshd_config.j2
       mode: '0644'
@@ -40,31 +40,31 @@
   tags: sshd
 
 - name: Copy sshd_config file
-  template:
+  ansible.builtin.template:
       src: templates/sshd_config.j2
       dest: /etc/ssh/sshd_config
       owner: root
       group: root
       mode: '0644'
-  notify: restart-sshd
+  notify: Restart SSHD
   tags: sshd
 
-- name: add pip package
-  apt:
+- name: Add pip package
+  ansible.builtin.apt:
       name: "{{ python_apt_packages }}"
       force: true
       install_recommends: false
 
-- name: check that chroot directory for SFTP users exist
-  file:
+- name: Check that chroot directory for SFTP users exist
+  ansible.builtin.file:
       name: /backup/sftp
       state: directory
       owner: root
       group: root
       mode: '0755'
 
-- name: check that directories for SFTP for all servers exist
-  file:
+- name: Check that directories for SFTP for all servers exist
+  ansible.builtin.file:
       name: /backup/sftp/{{ hostvars[item].inventory_hostname | lower }}
       state: directory
       owner: "{{  hostvars[item].backup_sftp_user }}"
@@ -72,8 +72,8 @@
       mode: '0755'
   with_items: "{{ groups.all | difference(groups.backup_server) }}"
 
-- name: check that directory for collecting openstack Cloud facts exists
-  file:
+- name: Check that directory for collecting openstack Cloud facts exists
+  ansible.builtin.file:
       name: /backup/{{ item }}
       state: directory
       owner: lefilament
@@ -85,12 +85,12 @@
       - odoo2
       - versions
 
-- name: install swift client
-  pip:
+- name: Install swift client
+  ansible.builtin.pip:
       name: "{{ swift_pip_packages }}"
 
 - name: Copy OpenStack Fact Collection scripts on server
-  template:
+  ansible.builtin.template:
       src: "{{ item.script }}.j2"
       dest: /root/{{ item.script }}
       owner: root
@@ -100,8 +100,8 @@
   loop_control:
       label: '{{ item.name }}'
 
-- name: add cron job to retrieve backup list every day
-  cron:
+- name: Add cron job to retrieve backup list every day
+  ansible.builtin.cron:
       name: "{{ item.name }}"
       minute: "{{ item.minute }}"
       hour: "{{ item.hour }}"