From 9f7efda6727b26e3976684bb675033504c13917f Mon Sep 17 00:00:00 2001
From: benjamin <benjamin@le-filament.com>
Date: Tue, 23 Aug 2022 14:05:42 +0200
Subject: [PATCH] [update] partner contribution view: remove is_loss column and
 filter payments on entry

---
 report/scop_contribution_report.py | 12 +++---------
 views/res_partner.xml              |  4 ----
 2 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/report/scop_contribution_report.py b/report/scop_contribution_report.py
index 7cbfcc5..0e06a3c 100644
--- a/report/scop_contribution_report.py
+++ b/report/scop_contribution_report.py
@@ -198,7 +198,9 @@ class ScopContributionReport(models.Model):
         payments_html = False
         if self.source == "odoo":
             invoice_ids = self.get_invoice_contribution()
-            payment_ids = invoice_ids.mapped("move_line_payment_ids")
+            payment_ids = invoice_ids.mapped("move_line_payment_ids").filtered(
+                lambda p: p.move_id.move_type == "entry"
+            )
             if payment_ids:
                 payments = payment_ids.mapped(
                     lambda p: {
@@ -208,14 +210,6 @@ class ScopContributionReport(models.Model):
                         "credit": p.credit,
                         "class": "",
                     }
-                    if p.move_id.move_type not in ("out_invoice", "out_refund")
-                    else {
-                        "date": p.date,
-                        "name": p.name,
-                        "ref": "",
-                        "credit": p.credit,
-                        "class": "text-danger",
-                    }
                 )
                 payments_html = self._get_html_table(payments)
         if not payments_html:
diff --git a/views/res_partner.xml b/views/res_partner.xml
index 43b0281..860677c 100644
--- a/views/res_partner.xml
+++ b/views/res_partner.xml
@@ -30,10 +30,6 @@
                                         <field name='amount_called' />
                                         <field name='amount_paid' />
                                         <field name='amount_due' />
-                                        <field
-                                            name='is_loss'
-                                            style="text-align: center;"
-                                        />
                                     </tree>
                                 </field>
                             </page>
-- 
GitLab